Skip to content

Rename ghi_from_poa_driesse_2023 to ghi_from_poa_driesse_2024#2777

Merged
kandersolar merged 7 commits into
pvlib:mainfrom
RDaxini:ghifrompoa_deprecation
Jun 10, 2026
Merged

Rename ghi_from_poa_driesse_2023 to ghi_from_poa_driesse_2024#2777
kandersolar merged 7 commits into
pvlib:mainfrom
RDaxini:ghifrompoa_deprecation

Conversation

@RDaxini

@RDaxini RDaxini commented Jun 9, 2026 •
edited
Loading

Copy link
Copy Markdown
Member
  • Closes Wrong year in function name: ghi_from_poa_driesse_2023 #2774
  • I am familiar with the contributing guidelines
  • I attest that all AI-generated material has been vetted for accuracy and is in compliance with the pvlib license
  • Tests added
  • Updates entries in docs/sphinx/source/reference for API changes.
  • Adds description and name entries in the appropriate "what's new" file in docs/sphinx/source/whatsnew for all changes. Includes link to the GitHub Issue with :issue:`num` or this Pull Request with :pull:`num`. Includes contributor name and/or GitHub username (link with :ghuser:`user`).
  • New code is fully documented. Includes numpydoc compliant docstrings, examples, and comments where necessary.
  • Pull request is nearly complete and ready for detailed review.
  • Maintainer: Appropriate GitHub Labels (including remote-data) and Milestone are assigned to the Pull Request and linked Issue.

@RDaxini RDaxini added api deprecation Use for issues and PRs which involve deprecations labels Jun 9, 2026
@RDaxini RDaxini added this to the v0.15.2 milestone Jun 9, 2026
@RDaxini RDaxini marked this pull request as ready for review June 9, 2026 15:50
@RDaxini RDaxini marked this pull request as draft June 9, 2026 15:51
@RDaxini RDaxini marked this pull request as ready for review June 9, 2026 18:36
@RDaxini RDaxini changed the title [WIP] Rename ghi_from_poa_driesse_2023 to ghi_from_poa_driesse_2024 Rename ghi_from_poa_driesse_2023 to ghi_from_poa_driesse_2024 Jun 9, 2026
kandersolar
kandersolar approved these changes Jun 9, 2026
View reviewed changes

@kandersolar kandersolar left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work @RDaxini, two very minor suggestions.

Comment thread docs/sphinx/source/whatsnew/v0.15.2.rst Outdated
Comment thread pvlib/irradiance.py
@echedey-ls

echedey-ls commented Jun 9, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

@kandersolar what is the scheduled version release for this month? To document exactly the version it is being deprecated in #2396 (and also to account for that in my non-existent spare time :c )

Edit: may it be time for a release preparation issue?

@echedey-ls echedey-ls mentioned this pull request Jun 9, 2026
Open
@kandersolar

kandersolar commented Jun 9, 2026

Copy link
Copy Markdown
Member

what is the scheduled version release for this month?

This one will be v0.15.2, unless some urgent breaking change appears in the next week.

may it be time for a release preparation issue?

Yes indeed. By coincidence, I started drafting that issue just a few minutes ago :P Thanks for keeping track!!

echedey-ls
echedey-ls approved these changes Jun 9, 2026
View reviewed changes

@echedey-ls echedey-ls left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Comment thread docs/sphinx/source/whatsnew/v0.15.2.rst Outdated
adriesse
adriesse approved these changes Jun 9, 2026
View reviewed changes

@adriesse adriesse left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Surprising number of occurrences, and even a test on the deprecation!

@RDaxini

RDaxini commented Jun 9, 2026

Copy link
Copy Markdown
Member Author

LGTM. Surprising number of occurrences, and even a test on the deprecation!

Have to be thorough 🫡

@kandersolar kandersolar merged commit 7929b38 into pvlib:main Jun 10, 2026
31 checks passed
@RDaxini RDaxini deleted the ghifrompoa_deprecation branch June 10, 2026 02:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kandersolar kandersolar kandersolar approved these changes

@adriesse adriesse adriesse approved these changes

+1 more reviewer

@echedey-ls echedey-ls echedey-ls approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

api deprecation Use for issues and PRs which involve deprecations

Projects

None yet

Milestone

v0.15.2

Development

Successfully merging this pull request may close these issues.

Wrong year in function name: ghi_from_poa_driesse_2023

4 participants

@RDaxini @echedey-ls @kandersolar @adriesse